Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMake SDist only could skip sdist step #766

Closed
henryiii opened this issue Jun 13, 2024 · 0 comments · Fixed by #812
Closed

CMake SDist only could skip sdist step #766

henryiii opened this issue Jun 13, 2024 · 0 comments · Fixed by #812
Milestone

Comments

@henryiii
Copy link
Collaborator

henryiii commented Jun 13, 2024

Currently I don't think it's useful to use CMake only in the SDist only step, as if someone builds a wheel from source, the SDist step won't run. We should consider this use case, and see if there's a way (maybe with overrides) to add controls for Source vs. from SDist builds.

I think if.from-sdist would do it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant