Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: from-sdist for overrides #812

Merged
merged 1 commit into from
Jul 19, 2024
Merged

feat: from-sdist for overrides #812

merged 1 commit into from
Jul 19, 2024

Conversation

henryiii
Copy link
Collaborator

@henryiii henryiii commented Jul 15, 2024

Close #766.

Will make sure it works for something like pybind11 first. Will need one more thing, so making this a followup.

Copy link

codecov bot commented Jul 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.20%. Comparing base (2b3e4d2) to head (e25fe40).
Report is 70 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #812      +/-   ##
==========================================
+ Coverage   83.18%   83.20%   +0.02%     
==========================================
  Files          73       73              
  Lines        4068     4073       +5     
==========================================
+ Hits         3384     3389       +5     
  Misses        684      684              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@henryiii henryiii force-pushed the henryiii/feat/from_sdist branch from cd3be8a to b73d18b Compare July 16, 2024 03:43
@henryiii henryiii mentioned this pull request Jul 18, 2024
4 tasks
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
@henryiii henryiii force-pushed the henryiii/feat/from_sdist branch from b73d18b to e25fe40 Compare July 19, 2024 18:36
@henryiii henryiii changed the title feat: from-cmake for overrides feat: from-sdist for overrides Jul 19, 2024
@henryiii henryiii merged commit 9bc0d97 into main Jul 19, 2024
51 checks passed
@henryiii henryiii deleted the henryiii/feat/from_sdist branch July 19, 2024 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CMake SDist only could skip sdist step
1 participant