-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: use dev version of FindPython #102
Conversation
The slashes are backwards in try-compile. I wonder if I'm injecting the wrong sort of path? |
dad26b4
to
df3b468
Compare
Codecov Report
@@ Coverage Diff @@
## main #102 +/- ##
==========================================
+ Coverage 90.29% 90.34% +0.05%
==========================================
Files 44 44
Lines 1844 1844
==========================================
+ Hits 1665 1666 +1
+ Misses 179 178 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Maybe some cmake code needs to be passed through |
5bafdf4
to
18cccd1
Compare
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com> tests: update
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
18cccd1
to
fa987eb
Compare
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
bbe3498
to
c142321
Compare
Thanks for working on this 🙏 I should be able to review in the few days👌 |
Okay, great. Let me know if you have any ideas for extra ways to test it; I'm already doing some basic testing, but it's not checking all paths through this file (and I think quite a few paths may never get hit due to the way we use this always knowing what Python interpreter we want). If it looks reasonable, it can go in - next version will be 0.2. |
Let's go ahead and put this in, and then it can be tweaked and adjusted later. I'd like to lean towards release early, release often, and get at least an dev release out for people to try in the next few days. |
This is now a port, see https://gitlab.kitware.com/cmake/cmake/-/issues/24185. Based on VTK's port at https://gitlab.kitware.com/vtk/vtk/-/blob/master/CMake/patches/3.23/FindPython/Support.cmake.
Support for the correct SOABI on PyPy and the Stable ABI are included.
Closes #148.