-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: build directory setting & reuse #181
Conversation
Codecov Report
@@ Coverage Diff @@
## main #181 +/- ##
==========================================
- Coverage 89.43% 89.18% -0.25%
==========================================
Files 44 44
Lines 1865 1887 +22
==========================================
+ Hits 1668 1683 +15
- Misses 197 204 +7
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Edit: There was a mistake. Now provides full benefit for non-isolated builds. Isolated builds get partial benefit (things like moving source files via pybind11 still cause rebuilds AFAICT). |
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
8e6033e
to
9479c50
Compare
Support for custom build directory, opt-in. Using
FORCE
for the moment. Doesn't try to rewrite the paths for moving CMake yet, but the info for this is there in the new json file.Maybe this shouldn't have a
cmake.
prefix? Edit: yes, looks like we could sync-up with meson-python if we just usebuild-dir
, so let's go with that. See mesonbuild/meson-python#275 forbuilddir
->build-dir
there.Might adjust this later. My thought is we can make this opt-in for now, then if we make it opt-out, we can protect the change on a minimum version selection.