Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: minor adustments to wheel returns #195

Merged
merged 2 commits into from
Feb 11, 2023
Merged

Conversation

henryiii
Copy link
Collaborator

  • docs: adding a note about build vs builder
  • chore: return structured data from wheel impl

Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
@codecov
Copy link

codecov bot commented Feb 10, 2023

Codecov Report

Merging #195 (f947d46) into main (7274af9) will increase coverage by 0.09%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #195      +/-   ##
==========================================
+ Coverage   89.40%   89.49%   +0.09%     
==========================================
  Files          45       45              
  Lines        2038     2046       +8     
==========================================
+ Hits         1822     1831       +9     
+ Misses        216      215       -1     
Impacted Files Coverage Δ
src/scikit_build_core/builder/__init__.py 100.00% <ø> (ø)
src/scikit_build_core/build/__init__.py 75.00% <100.00%> (ø)
src/scikit_build_core/build/wheel.py 80.48% <100.00%> (+1.35%) ⬆️
src/scikit_build_core/builder/builder.py 96.59% <0.00%> (+1.13%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@henryiii henryiii merged commit c27cc58 into main Feb 11, 2023
@henryiii henryiii deleted the henryiii/chore/mined branch February 11, 2023 00:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant