Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Self usage #199

Merged
merged 8 commits into from
Feb 14, 2023
Merged

chore: Self usage #199

merged 8 commits into from
Feb 14, 2023

Conversation

henryiii
Copy link
Collaborator

@henryiii henryiii commented Feb 14, 2023

Using self with mypy 1.0. Not requiring it at runtime. Typing extensions is required for <3.8 still, since it's used at runtime. Also enabling the shiny new --show-fixes in Ruff! :)

@codecov
Copy link

codecov bot commented Feb 14, 2023

Codecov Report

Merging #199 (5b1c3a8) into main (fa9f975) will decrease coverage by 0.03%.
The diff coverage is 91.66%.

❗ Current head 5b1c3a8 differs from pull request most recent head c37eb10. Consider uploading reports for the commit c37eb10 to get more accurate results

@@            Coverage Diff             @@
##             main     #199      +/-   ##
==========================================
- Coverage   89.49%   89.46%   -0.03%     
==========================================
  Files          45       45              
  Lines        2046     2050       +4     
==========================================
+ Hits         1831     1834       +3     
- Misses        215      216       +1     
Impacted Files Coverage Δ
src/scikit_build_core/_compat/typing.py 92.85% <85.71%> (-7.15%) ⬇️
src/scikit_build_core/build/_wheelfile.py 99.29% <100.00%> (-0.01%) ⬇️
src/scikit_build_core/builder/wheel_tag.py 83.33% <100.00%> (-0.23%) ⬇️
src/scikit_build_core/cmake.py 82.26% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
@henryiii henryiii changed the title chore: Self usage & no typing_extensions support chore: Self usage Feb 14, 2023
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
@henryiii henryiii merged commit 0d918bd into main Feb 14, 2023
@henryiii henryiii deleted the henryiii/chore/Self branch February 14, 2023 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant