Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: change editable.verbose to default True #268

Merged
merged 1 commit into from
Apr 12, 2023

Conversation

henryiii
Copy link
Collaborator

Since this isn't on by default and redirects to stderr, I think it's fine to default verbose to on.

Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
@codecov
Copy link

codecov bot commented Apr 12, 2023

Codecov Report

Merging #268 (f7c3328) into main (98ea9de) will decrease coverage by 0.07%.
The diff coverage is 42.85%.

@@            Coverage Diff             @@
##             main     #268      +/-   ##
==========================================
- Coverage   87.46%   87.40%   -0.07%     
==========================================
  Files          55       55              
  Lines        2394     2397       +3     
==========================================
+ Hits         2094     2095       +1     
- Misses        300      302       +2     
Impacted Files Coverage Δ
src/scikit_build_core/_logging.py 80.28% <20.00%> (-2.08%) ⬇️
src/scikit_build_core/settings/skbuild_model.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@henryiii henryiii merged commit 044171f into main Apr 12, 2023
@henryiii henryiii deleted the henryiii/refactor/defverb branch April 12, 2023 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant