Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: purelib should set py3 tag if unset #661

Merged
merged 1 commit into from
Mar 4, 2024
Merged

Conversation

henryiii
Copy link
Collaborator

@henryiii henryiii commented Mar 1, 2024

Followup to #655.

Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
Copy link

codecov bot commented Mar 1, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 86.44%. Comparing base (160bbca) to head (f7bca40).

Files Patch % Lines
src/scikit_build_core/builder/wheel_tag.py 33.33% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #661      +/-   ##
==========================================
- Coverage   86.46%   86.44%   -0.03%     
==========================================
  Files          64       64              
  Lines        3280     3282       +2     
==========================================
+ Hits         2836     2837       +1     
- Misses        444      445       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@henryiii henryiii merged commit 3ee1e1f into main Mar 4, 2024
51 of 53 checks passed
@henryiii henryiii deleted the henryiii/fix/purelib2 branch March 4, 2024 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant