Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: if for free-threading #819

Merged
merged 2 commits into from
Aug 2, 2024
Merged

feat: if for free-threading #819

merged 2 commits into from
Aug 2, 2024

Conversation

henryiii
Copy link
Collaborator

@henryiii henryiii commented Jul 19, 2024

I think this won't work on Windows yet, we'll need to find the flags another way there, I think. Now uses packaging.tags. Close #770.

@henryiii henryiii force-pushed the henryiii/feat/iffreethreading branch 2 times, most recently from c715173 to ea6c7f0 Compare July 19, 2024 22:51
Copy link

codecov bot commented Jul 19, 2024

Codecov Report

Attention: Patch coverage is 93.33333% with 1 line in your changes missing coverage. Please review.

Project coverage is 83.70%. Comparing base (6afb1d6) to head (ac07c66).
Report is 62 commits behind head on main.

Files with missing lines Patch % Lines
...rc/scikit_build_core/settings/skbuild_overrides.py 85.71% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #819      +/-   ##
==========================================
+ Coverage   83.68%   83.70%   +0.01%     
==========================================
  Files          74       74              
  Lines        4204     4227      +23     
==========================================
+ Hits         3518     3538      +20     
- Misses        686      689       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
@henryiii henryiii force-pushed the henryiii/feat/iffreethreading branch from ea6c7f0 to a939692 Compare July 31, 2024 18:54
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
@henryiii henryiii marked this pull request as ready for review August 2, 2024 03:21
@henryiii henryiii merged commit 545a83a into main Aug 2, 2024
52 checks passed
@henryiii henryiii deleted the henryiii/feat/iffreethreading branch August 2, 2024 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

if for free threaded?
1 participant