Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add messages config for failure/success #825

Merged
merged 2 commits into from
Jul 25, 2024
Merged

Conversation

henryiii
Copy link
Collaborator

See #112.

This includes .format() so that items can be added here later in a backward-compatible way.

Copy link

codecov bot commented Jul 25, 2024

Codecov Report

Attention: Patch coverage is 61.53846% with 15 lines in your changes missing coverage. Please review.

Project coverage is 83.56%. Comparing base (d977a08) to head (1666b8d).
Report is 65 commits behind head on main.

Files with missing lines Patch % Lines
src/scikit_build_core/build/__init__.py 28.57% 10 Missing ⚠️
src/scikit_build_core/build/wheel.py 66.66% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #825      +/-   ##
==========================================
- Coverage   83.76%   83.56%   -0.21%     
==========================================
  Files          74       74              
  Lines        4139     4173      +34     
==========================================
+ Hits         3467     3487      +20     
- Misses        672      686      +14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
@henryiii henryiii force-pushed the henryiii/feat/messages branch from 7a71736 to 8297a8c Compare July 25, 2024 17:21
@henryiii henryiii merged commit 625046f into main Jul 25, 2024
51 checks passed
@henryiii henryiii deleted the henryiii/feat/messages branch July 25, 2024 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant