-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add remove=
postprocess to regex
#828
Conversation
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #828 +/- ##
==========================================
+ Coverage 83.63% 83.68% +0.04%
==========================================
Files 74 74
Lines 4192 4204 +12
==========================================
+ Hits 3506 3518 +12
Misses 686 686 ☔ View full report in Codecov by Sentry. |
Was looking if this affects
Shouldn't this one be .public ? Fedora packaging uses the 1:a.b.c format to define epoch (enforcing to update to a lower version than the latest)
|
Isn't that what we want?
I think you mean As to the epoch, it is included in both, which is probably not ideal for us, as CMake won't be able to understand an epoch. |
Yes, it should, the result of the dynamic metadata plugin is used as the version. |
There is an example of
Python wise, yes. Was just mentioning because there could be a synchronization between those that might be used (after changing |
The examples are misleading, I've made pypa/packaging#818 to clarify the examples. Both of them include the epoch. Generally, the epoch is the most important version number (more than even the major number), so that's probably why it's always included. We could easily avoid it by manually constructing the number, though, since CMake won't be able to parse it. |
Ah indeed, the code right beneath it makes it more obvious :D |
See #828. CMake will not understand the epoch, so not including it. It's still in `SKBUILD_PROJECT_FULL_VERSION`. Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
See #828. CMake will not understand the epoch, so not including it. It's still in `SKBUILD_PROJECT_FULL_VERSION`. Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
This adds the ability to post-process regex to remove "dev0" or similar. Closes #765.