Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: detect manual generator setting for get_requires #840

Merged
merged 1 commit into from
Aug 1, 2024

Conversation

henryiii
Copy link
Collaborator

Fix #778.

Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
Copy link

codecov bot commented Jul 31, 2024

Codecov Report

Attention: Patch coverage is 70.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 83.66%. Comparing base (6afb1d6) to head (e86a3dc).
Report is 62 commits behind head on main.

Files with missing lines Patch % Lines
src/scikit_build_core/builder/get_requires.py 70.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #840      +/-   ##
==========================================
- Coverage   83.68%   83.66%   -0.02%     
==========================================
  Files          74       74              
  Lines        4204     4212       +8     
==========================================
+ Hits         3518     3524       +6     
- Misses        686      688       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@henryiii henryiii merged commit 4923ded into main Aug 1, 2024
52 checks passed
@henryiii henryiii deleted the henryiii/fix/genset branch August 1, 2024 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix: improve manual generator support in get_requires
1 participant