-
Notifications
You must be signed in to change notification settings - Fork 87
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix: adjust checks in ForthMachine to prevent segfault when num_items…
… is negative (#3209) * Adjusted checks in case num_items is negative * Added tests * Added documentation for new rule * Specify dtype for numpy arrays
- Loading branch information
Showing
3 changed files
with
63 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
45 changes: 45 additions & 0 deletions
45
tests/test_3209_awkwardforth_read_negative_number_of_items.py
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,45 @@ | ||
# BSD 3-Clause License; see https://github.com/scikit-hep/awkward/blob/main/LICENSE | ||
|
||
from __future__ import annotations | ||
|
||
import numpy as np | ||
|
||
import awkward as ak | ||
|
||
|
||
def test_read_negative_number_of_items(): | ||
vm = ak.forth.ForthMachine32("input source -5 source #q-> stack") | ||
vm.run({"source": np.array([1, 2, 3, 4, 5], dtype=np.int64)}) | ||
assert vm.stack == [] | ||
|
||
vm = ak.forth.ForthMachine32("input source output sink float64 -5 source #q-> sink") | ||
vm.run({"source": np.array([1, 2, 3, 4, 5], dtype=np.int64)}) | ||
assert vm.output("sink").tolist() == [] | ||
|
||
|
||
def test_read_negative_and_positive_number_of_items(): | ||
vm = ak.forth.ForthMachine32( | ||
"input source -5 source #q-> stack 5 source #q-> stack" | ||
) | ||
vm.run({"source": np.array([1, 2, 3, 4, 5], dtype=np.int64)}) | ||
assert vm.stack == [1, 2, 3, 4, 5] | ||
|
||
vm = ak.forth.ForthMachine32( | ||
"input source output sink float64 -5 source #q-> sink 5 source #q-> sink" | ||
) | ||
vm.run({"source": np.array([1, 2, 3, 4, 5], dtype=np.int64)}) | ||
assert vm.output("sink").tolist() == [1, 2, 3, 4, 5] | ||
|
||
|
||
def test_read_positive_and_negative_number_of_items(): | ||
vm = ak.forth.ForthMachine32( | ||
"input source 5 source #q-> stack -5 source #q-> stack" | ||
) | ||
vm.run({"source": np.array([1, 2, 3, 4, 5], dtype=np.int64)}) | ||
assert vm.stack == [1, 2, 3, 4, 5] | ||
|
||
vm = ak.forth.ForthMachine32( | ||
"input source output sink float64 5 source #q-> sink -5 source #q-> sink" | ||
) | ||
vm.run({"source": np.array([1, 2, 3, 4, 5], dtype=np.int64)}) | ||
assert vm.output("sink").tolist() == [1, 2, 3, 4, 5] |