Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build wheels for ppc64le #1224

Merged
merged 2 commits into from
Jan 20, 2022
Merged

Conversation

chrisburr
Copy link
Member

I've found myself having a need for POWER wheels for awkward array. What do you think about including them in the PyPI releases? I'm excluding Python 3.6 and 3.7 to shrink the build matrix but it's up to you if you want to keep that part.

@codecov
Copy link

codecov bot commented Jan 13, 2022

Codecov Report

Merging #1224 (1906456) into main (0a0e9be) will decrease coverage by 1.21%.
The diff coverage is 71.87%.

Impacted Files Coverage Δ
src/awkward/_v2/contents/emptyarray.py 69.54% <ø> (ø)
src/awkward/_v2/contents/content.py 81.74% <23.07%> (-1.45%) ⬇️
src/awkward/_v2/_typetracer.py 68.94% <33.33%> (-0.25%) ⬇️
src/awkward/_v2/_slicing.py 83.79% <75.47%> (-2.48%) ⬇️
src/awkward/_v2/contents/regulararray.py 82.66% <80.00%> (+0.07%) ⬆️
src/awkward/_v2/contents/unionarray.py 83.59% <95.45%> (+0.19%) ⬆️
src/awkward/_v2/tmp_for_testing.py 5.31% <0.00%> (-77.78%) ⬇️
src/awkward/_v2/contents/bitmaskedarray.py 64.45% <0.00%> (-0.79%) ⬇️
src/awkward/_v2/highlevel.py 64.43% <0.00%> (-0.56%) ⬇️
... and 13 more

@jpivarski
Copy link
Member

I'm fine with this, including the restriction on Python version for particular hardware.

It should probably also get tested in regular CI. That could be hard to do with the Azure tests, but we also run some GitHub Actions tests in CI: .github/workflows/tests.yml. Since wheels.yml and tests.yml are on the same system, is it easy to add this as a test?

@chrisburr
Copy link
Member Author

It seems like you currently don't do any CI for the aarch64 builds except for when deploying releases?

It should be possible to set up on either GitHub actions or Azure however it will be quite slow as it's using emulation (from experience elsewhere it'll be ~5x slower).

@jpivarski
Copy link
Member

As I understand it, we're moving from Azure to GitHub Actions, and that's partially done through some GitHub Actions tests in CI that aren't currently required. (I could make them required.)

The current Azure tests do the combinations of {x86_64 Linux, Mac, Windows} × {Python versions}, which are all the same hardware (x86_64). Azure only covers continuous testing, not deployment.

The GitHub Actions that deploy (wheels.yml) have a variety of architectures, recently added by @henryiii.

There are a few GitHub Actions that run in continuous testing (test.yml). I would think that they should test all the same architectures that get deployed. The advantages of doing it in test.yml are that this is what we're moving to and the syntax will be the same as for deployment. These tests are not currently required, but I can make them so.

I didn't realize that there are architectures that get deployed as wheels without testing. The deployment process itself invokes the tests, but wheels.yml only gets triggered manually or in an actual release. If a bug breaks an architecture, we'd want to know that sooner.

@jpivarski
Copy link
Member

I'm doing a prerelease now, so let's take this as-is to see if it works in the full deployment machinery. I'll revisit this question of whether these hardware architectures (ARM, PowerPC) get regularly tested.

@jpivarski jpivarski merged commit b188cdb into scikit-hep:main Jan 20, 2022
jpivarski added a commit that referenced this pull request Jan 20, 2022
jpivarski added a commit that referenced this pull request Jan 20, 2022
@chrisburr chrisburr deleted the ppc64le-wheels branch January 27, 2022 15:29
@chrisburr chrisburr restored the ppc64le-wheels branch January 27, 2022 15:30
@chrisburr chrisburr deleted the ppc64le-wheels branch January 27, 2022 15:30
@jpivarski
Copy link
Member

Hi Chris,

This was a few years ago, but somehow I missed adding you to our list of contributors for this work. Sorry!

@all-contributors please add @chrisburr for infra

Copy link
Contributor

@jpivarski

I couldn't determine any contributions to add, did you specify any contributions?
Please make sure to use valid contribution names.

I've put up a pull request to add @chrisburr! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants