-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: how to accelerate awkward arrays with cppyy #2334
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@agoose77 - please, suggest what is the best place for Awkward-cppyy JIT. Thanks.
@ianna I think creating a new section was a good decision. I've renamed it to If you and @jpivarski agree, then I won't yet move the layout-builder documentation here; I'll make a new PR for that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This has the same fix in it as #2335, so it should be merged afterward.
Also, it should be merged after cppyy 3.0.1 is released (watch this space) and converted into Jupytext that gets evaluated along with the other docs (that's the requested change). The rationale is that we shouldn't put documentation out there for a feature that users can't use... without manually installing cppyy from GitHub and compiling it for half an hour...
The escape valve to allow unevaluated ipynb docs should only be used for GPU docs, since they have to avoid the normal mechanism. For a library that isn't released yet, we can just wait for it to be released. This PR will be easy to merge when that happens.
13d39a8
to
397c320
Compare
Well, that took some figuring out. I wrote a build script to run inside a For the tests, we install the wheels in a dedicated non-ROOT cppyy job. For the docs, we have a dedicated build-the-cppyy-notebook job that does a similar thing. This is a somewhat ugly procedure: I'd prefer to push the wheels to a PyPI registry, but off the top of my head I can't think of any non PyPI-registries that we can easily use (though we could push to an AWS bucket). Once In this PR I also attempted to upgrade our pyodide toolchain. Unfortunately, there are yet more out-of-tree bugs in pyodide whose fixes have yet to be released. So, that's on the bench for a while. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@agoose77 - thanks for looking into it! I've already forgotten about this PR :-)
@jpivarski I've added a new section to the user guide: I've not renamed the actual file for the existing LayoutBuilder docs; this means that we don't need to rewrite the URLs for existing hyperlinks in the wild. Once I've checked the deployment, I'll merge if you give this a 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fantastic! We're in a slightly odd position of having documentation for this feature and testing it in CI, but users still can't install the right version of cppyy to use it. I noticed that my comment holding it back was waiting on cppyy 3.0.1 since March. But let's get the documentation out now so that it's ready when cppyy is.
When the easily installable version of cppyy does come out, though, we'll want to use that. Perhaps it won't have these warning messages...
This is ready to merge, though, as-is.
This PR adds:
See #2334 (comment) for information on the CI/CD changes.
TODO