Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace carry with indexedarray #261

Merged
merged 28 commits into from
Jun 30, 2020

Commits on May 12, 2020

  1. Configuration menu
    Copy the full SHA
    a29d2ef View commit details
    Browse the repository at this point in the history

Commits on Jun 16, 2020

  1. add a copy flag for carry

    ianna committed Jun 16, 2020
    Configuration menu
    Copy the full SHA
    37ef9a2 View commit details
    Browse the repository at this point in the history
  2. switch to indexedarray in carry and comment out the segfalting tests:

    fail in highlevel.py line 839
    	modified:   tests/test_0025-record-array.py
    	modified:   tests/test_0056-partitioned-array.py
    	modified:   tests/test_0084-start-unionarray.py
    	modified:   tests/test_0111-jagged-and-masked-getitem.py
    	modified:   tests/test_0117-finish-the-sizes-operation.py
    ianna committed Jun 16, 2020
    Configuration menu
    Copy the full SHA
    49b3929 View commit details
    Browse the repository at this point in the history

Commits on Jun 17, 2020

  1. use an eager projection

    ianna committed Jun 17, 2020
    Configuration menu
    Copy the full SHA
    887353c View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    5bb7dfa View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    6db41c5 View commit details
    Browse the repository at this point in the history
  4. fix listoffsetarray test

    ianna committed Jun 17, 2020
    Configuration menu
    Copy the full SHA
    9500950 View commit details
    Browse the repository at this point in the history
  5. fix unionarray project

    ianna committed Jun 17, 2020
    Configuration menu
    Copy the full SHA
    efbeb0b View commit details
    Browse the repository at this point in the history
  6. remove comment

    ianna committed Jun 17, 2020
    Configuration menu
    Copy the full SHA
    812e264 View commit details
    Browse the repository at this point in the history
  7. add comments for failing tests

    ianna committed Jun 17, 2020
    Configuration menu
    Copy the full SHA
    429c625 View commit details
    Browse the repository at this point in the history
  8. eager carry in gettiem

    ianna committed Jun 17, 2020
    Configuration menu
    Copy the full SHA
    d3dfaff View commit details
    Browse the repository at this point in the history
  9. Merge branch 'master' of https://github.com/scikit-hep/awkward-1.0 in…

    …to ianna/recordarray-carry-to-return-indexedarray
    ianna committed Jun 17, 2020
    Configuration menu
    Copy the full SHA
    97119d0 View commit details
    Browse the repository at this point in the history

Commits on Jun 18, 2020

  1. address Jim's comments

    ianna committed Jun 18, 2020
    Configuration menu
    Copy the full SHA
    96bd348 View commit details
    Browse the repository at this point in the history
  2. lazy carry

    ianna committed Jun 18, 2020
    Configuration menu
    Copy the full SHA
    c195654 View commit details
    Browse the repository at this point in the history
  3. revert adding a line

    ianna committed Jun 18, 2020
    Configuration menu
    Copy the full SHA
    5d6ca9a View commit details
    Browse the repository at this point in the history

Commits on Jun 19, 2020

  1. add more identity tests

    ianna committed Jun 19, 2020
    Configuration menu
    Copy the full SHA
    616573d View commit details
    Browse the repository at this point in the history

Commits on Jun 22, 2020

  1. Configuration menu
    Copy the full SHA
    4a8612d View commit details
    Browse the repository at this point in the history

Commits on Jun 23, 2020

  1. don't sort array second time

    ianna committed Jun 23, 2020
    Configuration menu
    Copy the full SHA
    41e2f15 View commit details
    Browse the repository at this point in the history

Commits on Jun 28, 2020

  1. Configuration menu
    Copy the full SHA
    07120fd View commit details
    Browse the repository at this point in the history

Commits on Jun 29, 2020

  1. allow lazy carry explicitly

    ianna committed Jun 29, 2020
    Configuration menu
    Copy the full SHA
    c27a4e5 View commit details
    Browse the repository at this point in the history

Commits on Jun 30, 2020

  1. Configuration menu
    Copy the full SHA
    58e5603 View commit details
    Browse the repository at this point in the history
  2. Step 2: explicit 'allow_lazy' in all calling sites, rather than defau…

    …lt 'allow_lazy = false'.
    jpivarski committed Jun 30, 2020
    Configuration menu
    Copy the full SHA
    0fa8402 View commit details
    Browse the repository at this point in the history
  3. Step 3: most IndexedArray methods calling 'carry' should be eager, wi…

    …th the definite exception of 'combinations' and the possible exception of 'getitem_next' (leaving it for now). Same for 'ListOffsetArray::reduce_next'.
    jpivarski committed Jun 30, 2020
    Configuration menu
    Copy the full SHA
    ee73b59 View commit details
    Browse the repository at this point in the history
  4. Step 4: fixing one infinite loop, all getitem_next for at, range, arr…

    …ay, and jagged all use lazy carrys. Error in identities (test_0025-record-array) has been reopened: will be fixing that next.
    jpivarski committed Jun 30, 2020
    Configuration menu
    Copy the full SHA
    0aaaddd View commit details
    Browse the repository at this point in the history
  5. Step 5: far from introducing a bug, this change actually revealed a l…

    …ong-standing bug in RecordArray::getitem_range_nowrap: it was not propagating Identities at all, though it should have been.
    jpivarski committed Jun 30, 2020
    Configuration menu
    Copy the full SHA
    a18221d View commit details
    Browse the repository at this point in the history
  6. A few last fixes for consistency: all jagged slices should allow_lazy…

    … (except IndexedArray, which runs the risk of an infinite loop), and ByteMaskedArray::carry should pass down allow_lazy to its content.
    jpivarski committed Jun 30, 2020
    Configuration menu
    Copy the full SHA
    17d1292 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    b04a08a View commit details
    Browse the repository at this point in the history
  8. One last consistency-fix (in broadcast_tooffsets64) ensures that reco…

    …rds are lazily carried in all operations that broadcast (i.e. all operations that take more than one array argument).
    jpivarski committed Jun 30, 2020
    Configuration menu
    Copy the full SHA
    088c48a View commit details
    Browse the repository at this point in the history