-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
replace carry with indexedarray #261
replace carry with indexedarray #261
Commits on May 12, 2020
-
Configuration menu - View commit details
-
Copy full SHA for a29d2ef - Browse repository at this point
Copy the full SHA a29d2efView commit details
Commits on Jun 16, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 37ef9a2 - Browse repository at this point
Copy the full SHA 37ef9a2View commit details -
switch to indexedarray in carry and comment out the segfalting tests:
fail in highlevel.py line 839 modified: tests/test_0025-record-array.py modified: tests/test_0056-partitioned-array.py modified: tests/test_0084-start-unionarray.py modified: tests/test_0111-jagged-and-masked-getitem.py modified: tests/test_0117-finish-the-sizes-operation.py
Configuration menu - View commit details
-
Copy full SHA for 49b3929 - Browse repository at this point
Copy the full SHA 49b3929View commit details
Commits on Jun 17, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 887353c - Browse repository at this point
Copy the full SHA 887353cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5bb7dfa - Browse repository at this point
Copy the full SHA 5bb7dfaView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6db41c5 - Browse repository at this point
Copy the full SHA 6db41c5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9500950 - Browse repository at this point
Copy the full SHA 9500950View commit details -
Configuration menu - View commit details
-
Copy full SHA for efbeb0b - Browse repository at this point
Copy the full SHA efbeb0bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 812e264 - Browse repository at this point
Copy the full SHA 812e264View commit details -
Configuration menu - View commit details
-
Copy full SHA for 429c625 - Browse repository at this point
Copy the full SHA 429c625View commit details -
Configuration menu - View commit details
-
Copy full SHA for d3dfaff - Browse repository at this point
Copy the full SHA d3dfaffView commit details -
Merge branch 'master' of https://github.com/scikit-hep/awkward-1.0 in…
…to ianna/recordarray-carry-to-return-indexedarray
Configuration menu - View commit details
-
Copy full SHA for 97119d0 - Browse repository at this point
Copy the full SHA 97119d0View commit details
Commits on Jun 18, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 96bd348 - Browse repository at this point
Copy the full SHA 96bd348View commit details -
Configuration menu - View commit details
-
Copy full SHA for c195654 - Browse repository at this point
Copy the full SHA c195654View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5d6ca9a - Browse repository at this point
Copy the full SHA 5d6ca9aView commit details
Commits on Jun 19, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 616573d - Browse repository at this point
Copy the full SHA 616573dView commit details
Commits on Jun 22, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 4a8612d - Browse repository at this point
Copy the full SHA 4a8612dView commit details
Commits on Jun 23, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 41e2f15 - Browse repository at this point
Copy the full SHA 41e2f15View commit details
Commits on Jun 28, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 07120fd - Browse repository at this point
Copy the full SHA 07120fdView commit details
Commits on Jun 29, 2020
-
Configuration menu - View commit details
-
Copy full SHA for c27a4e5 - Browse repository at this point
Copy the full SHA c27a4e5View commit details
Commits on Jun 30, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 58e5603 - Browse repository at this point
Copy the full SHA 58e5603View commit details -
Step 2: explicit 'allow_lazy' in all calling sites, rather than defau…
…lt 'allow_lazy = false'.
Configuration menu - View commit details
-
Copy full SHA for 0fa8402 - Browse repository at this point
Copy the full SHA 0fa8402View commit details -
Step 3: most IndexedArray methods calling 'carry' should be eager, wi…
…th the definite exception of 'combinations' and the possible exception of 'getitem_next' (leaving it for now). Same for 'ListOffsetArray::reduce_next'.
Configuration menu - View commit details
-
Copy full SHA for ee73b59 - Browse repository at this point
Copy the full SHA ee73b59View commit details -
Step 4: fixing one infinite loop, all getitem_next for at, range, arr…
…ay, and jagged all use lazy carrys. Error in identities (test_0025-record-array) has been reopened: will be fixing that next.
Configuration menu - View commit details
-
Copy full SHA for 0aaaddd - Browse repository at this point
Copy the full SHA 0aaadddView commit details -
Step 5: far from introducing a bug, this change actually revealed a l…
…ong-standing bug in RecordArray::getitem_range_nowrap: it was not propagating Identities at all, though it should have been.
Configuration menu - View commit details
-
Copy full SHA for a18221d - Browse repository at this point
Copy the full SHA a18221dView commit details -
A few last fixes for consistency: all jagged slices should allow_lazy…
… (except IndexedArray, which runs the risk of an infinite loop), and ByteMaskedArray::carry should pass down allow_lazy to its content.
Configuration menu - View commit details
-
Copy full SHA for 17d1292 - Browse repository at this point
Copy the full SHA 17d1292View commit details -
Configuration menu - View commit details
-
Copy full SHA for b04a08a - Browse repository at this point
Copy the full SHA b04a08aView commit details -
One last consistency-fix (in broadcast_tooffsets64) ensures that reco…
…rds are lazily carried in all operations that broadcast (i.e. all operations that take more than one array argument).
Configuration menu - View commit details
-
Copy full SHA for 088c48a - Browse repository at this point
Copy the full SHA 088c48aView commit details