Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add trove classifier to awkward-cpp #2729

Merged
merged 1 commit into from
Oct 25, 2023
Merged

chore: add trove classifier to awkward-cpp #2729

merged 1 commit into from
Oct 25, 2023

Conversation

agoose77
Copy link
Collaborator

@agoose77 agoose77 commented Sep 28, 2023 •
edited
Loading

This PR adds the Python 3.12 classifier to awkward-cpp

jpivarski
jpivarski approved these changes Sep 28, 2023
View reviewed changes
Copy link
Member

@jpivarski jpivarski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can merge it and leave it for the next time we have to make a release.

This looks like it's done to me, but since it's a draft, I'll let you merge.

@codecov
Copy link

codecov bot commented Sep 28, 2023

Codecov Report

Merging #2729 (c3571ec) into main (5534105) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

@agoose77 agoose77 temporarily deployed to docs-preview September 28, 2023 19:24 — with GitHub Actions Inactive
@agoose77 agoose77 added the pr-on-hold This PR is inactive due to a pending decision or other constraint label Sep 29, 2023
@agoose77 agoose77 marked this pull request as ready for review September 29, 2023 10:33
@agoose77 agoose77 changed the title fix: add trove classifier to awkward-cpp chore: add trove classifier to awkward-cpp Oct 25, 2023
@agoose77 agoose77 force-pushed the agoose77/fix-cpp-trove-classifier branch from c3571ec to 7eec378 Compare October 25, 2023 09:16
@agoose77 agoose77 merged commit 17aabde into main Oct 25, 2023
29 of 31 checks passed
@agoose77 agoose77 deleted the agoose77/fix-cpp-trove-classifier branch October 25, 2023 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpivarski jpivarski jpivarski approved these changes

Assignees
No one assigned
Labels
pr-on-hold This PR is inactive due to a pending decision or other constraint
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@agoose77 @jpivarski