-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: update cppyy module #2747
fix: update cppyy module #2747
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@agoose77 and @jpivarski - preparing for PyHEP I've discovered that cppyy test would fail. I wonder if this patch can be integrated in the next release asap. Thanks!
Codecov Report
Additional details and impacted files
|
@ianna I presume we need to install cppyy from source to obtain the supported version? Perhaps we should add a CI job to do this. When obtaining cppyy from Git, do you locally need to bump the version to 3.0.1? |
yes
yes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, ak._util.parse_version
was removed in 11e61b6#diff-5b25481afa0bba148a54d46dfc93af8141dfa50dcb399c55bb7df34f3af40f64
The dangerous-looking
import awkward._connect.cling
happens inside of the non-inspectable ak.Array.cpp_type
property, so it's safe.
I think this is ready to go and will merge it.
Thanks for merging this @jpivarski, I missed Ianna's reply! |
cppyy module relied on ak._utils to check the version.
Also we need to import cling. I'm not sure this is the best place, but it works: