Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: revert breaking component of asarray PR #2752

Merged
merged 3 commits into from
Oct 12, 2023

Conversation

agoose77
Copy link
Collaborator

This PR reverts the breaking parts of #2740 to introduce a deprecation period.

@codecov
Copy link

codecov bot commented Oct 11, 2023

Codecov Report

Merging #2752 (e8fff34) into main (0e27b90) will decrease coverage by 0.01%.
Report is 2 commits behind head on main.
The diff coverage is 73.17%.

Additional details and impacted files
Files Coverage Δ
src/awkward/contents/indexedarray.py 78.99% <100.00%> (ø)
src/awkward/contents/indexedoptionarray.py 88.48% <100.00%> (ø)
src/awkward/contents/unmaskedarray.py 74.40% <100.00%> (ø)
src/awkward/operations/ak_flatten.py 93.47% <100.00%> (ø)
src/awkward/operations/ak_run_lengths.py 90.12% <100.00%> (ø)
src/awkward/operations/ak_to_dataframe.py 90.55% <100.00%> (-0.08%) ⬇️
src/awkward/operations/ak_to_categorical.py 93.54% <50.00%> (ø)
src/awkward/operations/ak_unflatten.py 96.15% <75.00%> (ø)
src/awkward/contents/emptyarray.py 75.12% <50.00%> (-0.50%) ⬇️
src/awkward/contents/numpyarray.py 91.22% <50.00%> (-0.32%) ⬇️
... and 1 more

... and 1 file with indirect coverage changes

Copy link
Member

@jpivarski jpivarski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Index.__array__ would need the same deprecation period.

@agoose77 agoose77 merged commit 0627266 into main Oct 12, 2023
37 checks passed
@agoose77 agoose77 deleted the agoose77/fix-restore-breaking-asarray branch October 12, 2023 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants