fix: add highlevel, behavior arguments to composite reducers
#2754
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files
|
jpivarski
approved these changes
Oct 13, 2023
|
This looks done, it's a straightforward fix, and it has been hours since you touched it, so I'm going to merge it. |
jpivarski
deleted the
agoose77/feat-add-highlevel-args-composite-reducers
branch
agoose77
commented
Oct 14, 2023
Comment on lines
+39
to
+63
| def maybe_highlevel_to_lowlevel(obj): | ||
| """ | ||
| Args: | ||
| obj: an object | ||
|
|
||
| Calls #ak.to_layout and returns the result iff. the object is a high-level | ||
| Awkward object, otherwise the object is returned as-is. | ||
|
|
||
| This function should be removed once scalars are properly handled by `to_layout`. | ||
| """ | ||
| import awkward.highlevel | ||
|
|
||
| if isinstance( | ||
| obj, | ||
| ( | ||
| awkward.highlevel.Array, | ||
| awkward.highlevel.Record, | ||
| awkward.highlevel.ArrayBuilder, | ||
| ), | ||
| ): | ||
| return awkward.to_layout(obj) | ||
| else: | ||
| return obj | ||
|
|
||
|
|
There was a problem hiding this comment.
We will get rid of this function once our policies for ak.to_layout of scalars are more well defined.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A number of high-level operations in Awkward Array did not accept the
highlevelorbehaviorarguments. I don't think we ever explicitly decided upon this, so I assume that it is an oversight in need of correction!