Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: export nan variants #2758

Merged
merged 1 commit into from
Oct 16, 2023
Merged

fix: export nan variants #2758

merged 1 commit into from
Oct 16, 2023

Conversation

agoose77
Copy link
Collaborator

@agoose77 agoose77 commented Oct 16, 2023

We have high-level ak.XXX reducers that include nan-aware variants. We should export those!

@agoose77 agoose77 force-pushed the agoose77/fix-export-nan-variants branch from 40a2000 to 9ddc907 Compare October 16, 2023 14:41
@codecov
Copy link

codecov bot commented Oct 16, 2023

Codecov Report

Merging #2758 (9ddc907) into main (2748c0c) will not change coverage.
The diff coverage is 100.00%.

Additional details and impacted files
Files Coverage Δ
src/awkward/operations/ak_argmax.py 87.50% <100.00%> (ø)
src/awkward/operations/ak_argmin.py 87.50% <100.00%> (ø)
src/awkward/operations/ak_max.py 87.50% <100.00%> (ø)
src/awkward/operations/ak_mean.py 87.23% <100.00%> (ø)
src/awkward/operations/ak_min.py 87.50% <100.00%> (ø)
src/awkward/operations/ak_prod.py 87.50% <100.00%> (ø)
src/awkward/operations/ak_std.py 83.72% <100.00%> (ø)
src/awkward/operations/ak_sum.py 87.50% <100.00%> (ø)
src/awkward/operations/ak_var.py 82.00% <100.00%> (ø)

Copy link
Member

@jpivarski jpivarski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops; that was added and tested in awkward._v2 (#1325 (comment)), but must have gotten lost when the submodule got promoted.

I'll merge this now.

@jpivarski jpivarski merged commit c10b381 into main Oct 16, 2023
38 checks passed
@jpivarski jpivarski deleted the agoose77/fix-export-nan-variants branch October 16, 2023 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants