-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: support all-None
index in awkward_Index_nones_as_index.cpp
#2769
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpivarski
approved these changes
Oct 24, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Patching is good. The definition should also be updated here:
awkward/kernel-specification.yml
Lines 4501 to 4510 in 8927adb
definition: | | |
def awkward_Index_nones_as_index(toindex, length): | |
last_index = 0 | |
for i in range(length): | |
if toindex[i] > last_index: | |
last_index = toindex[i] | |
for i in range(length): | |
if toindex[i] == -1: | |
last_index = last_index + 1 | |
toindex[i] = last_index |
Eek, nearly forgot that. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #2768 by adding support for the all-none case to our
awkward_Index_nones_as_index.cpp
kernel. It also ensures that if we're argsorting the final dimension, we drop the option type from that dimension i.e. for this argsort result[10, 20, None, 5] → [3, 0, 1, 4]
the array doesn't contain anyNone
.I think we should probably refactor this logic, but right now that's not the highest priority, so I've just patched