Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fix oldest-supported-dependencies test workflow #2783

Merged
merged 5 commits into from
Oct 30, 2023

Conversation

agoose77
Copy link
Collaborator

@agoose77 agoose77 commented Oct 28, 2023

It turns out that our CI wasn't properly testing the package combinations that we'd asked it to — there were subsequent install steps that overwrote the intended variations. This means that #2767 was not properly tested against older versions of NumPy, leading to a bug.

Although it's possible to use multiple install steps, it best reflects our intentions if we use a single install command.

In future, we probably just want to have a single requirements.txt file, and a separate constraints.txt that pins these dependency versions on our lower-bound configuration. However, we don't currently test all dependencies at the lower bound. This PR only runs core tests (NumPy + PyArrow) in the 3.8 tests.

Fixes #2784

@codecov
Copy link

codecov bot commented Oct 28, 2023

Codecov Report

Merging #2783 (14aebfd) into main (3f623ee) will decrease coverage by 0.08%.
The diff coverage is 57.53%.

Additional details and impacted files
Files Coverage Δ
src/awkward/_nplikes/numpylike.py 73.72% <ø> (ø)
src/awkward/_nplikes/cupy.py 36.78% <33.33%> (-0.43%) ⬇️
src/awkward/_nplikes/array_module.py 84.15% <66.66%> (-3.35%) ⬇️
src/awkward/_nplikes/typetracer.py 75.33% <50.00%> (-1.26%) ⬇️

@agoose77
Copy link
Collaborator Author

agoose77 commented Oct 28, 2023

414f69a should break the CI, such that 6c708c6 fixes it!

@agoose77 agoose77 temporarily deployed to docs October 28, 2023 09:18 — with GitHub Actions Inactive
@agoose77 agoose77 force-pushed the agoose77/fix-ci-version-tests branch from 84320c4 to 4da1997 Compare October 28, 2023 09:49
@agoose77 agoose77 temporarily deployed to docs October 28, 2023 09:59 — with GitHub Actions Inactive
@agoose77 agoose77 temporarily deployed to docs October 28, 2023 10:29 — with GitHub Actions Inactive
@agoose77 agoose77 force-pushed the agoose77/fix-ci-version-tests branch from 28f8055 to 6c708c6 Compare October 28, 2023 12:20
@agoose77 agoose77 temporarily deployed to docs October 28, 2023 12:29 — with GitHub Actions Inactive
@agoose77 agoose77 temporarily deployed to docs October 28, 2023 13:00 — with GitHub Actions Inactive
@agoose77 agoose77 temporarily deployed to docs October 28, 2023 13:53 — with GitHub Actions Inactive
@agoose77 agoose77 temporarily deployed to docs October 28, 2023 14:19 — with GitHub Actions Inactive
@agoose77 agoose77 temporarily deployed to docs October 28, 2023 20:02 — with GitHub Actions Inactive
@agoose77 agoose77 temporarily deployed to docs October 29, 2023 22:41 — with GitHub Actions Inactive
@agoose77 agoose77 force-pushed the agoose77/fix-ci-version-tests branch from bf96837 to aeeb3f6 Compare October 29, 2023 22:49
@agoose77 agoose77 temporarily deployed to docs October 30, 2023 09:08 — with GitHub Actions Inactive
@agoose77 agoose77 marked this pull request as ready for review October 30, 2023 11:04
@agoose77 agoose77 changed the title ci: perform installs in single pass ci: fix oldest-supported-dependencies test workflow Oct 30, 2023
Copy link
Member

@jpivarski jpivarski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR fixes both the test infrastructure and also the bug for old versions of NumPy. I strongly approve of the use of a NUMPY_HAS_NEP_50 instead of finding a solution that works for both old and new NumPy, so that we know what to remove when our minimum NumPy does get to be 1.24 or above.

I think this is ready to merge!

@agoose77 agoose77 merged commit 5665d85 into main Oct 30, 2023
37 checks passed
@agoose77 agoose77 deleted the agoose77/fix-ci-version-tests branch October 30, 2023 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NumPy 1.18 is not properly supported
2 participants