Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables
mypy
checks on a subset of the codebase and runs it as part of CI.Right now, we don't publicly declare type-hints via
py.typed
, so these are only used internally.Some things don't type super well; the
Sentinel
singleton doesn't seem very easy to handle. The closest we could get I think is to use e.g.But for now, we'll just ignore this part of the typing.
We're not running in strict mode, so this only checks places where we declare types.