fix: remove old argument from broadcast_and_apply
#2790
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A recent PR made this change, but it looks like I missed one usage. I've made the function keyword-only for the non-leading arguments.
broadcast_and_apply
is an internal function, but I also think these functions benefit from this change: future refactors will throw exceptions rather than silently re-interpreting an argument, and it helps readability. Incidentally, that's how most of the usages ofbroadcast_and_apply
are written; keyword arguments for the non-leading order args.As this fixes a bug that's clearly from a previous PR, and it doesn't change any behaviour, I'm going to merge in the interest of unblocking main.