fix: don't preserve unexpected option for is_in #2792
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PyArrow 14 started returning an option type, which follows from the new
null_matching_behavior
option.@jpivarski I'm wondering about the
_drop_option_preserving_form
helper function that we use to erase options. Should we only check the bitmasks being erased in our test suite? i.e., at production, we don't assert that each entry is 0, but rather assume that the operation doesn't do this — the mask is just PyArrow adding a mask node?