Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't preserve unexpected option for is_in #2792

Merged
merged 2 commits into from
Nov 1, 2023

Conversation

agoose77
Copy link
Collaborator

@agoose77 agoose77 commented Nov 1, 2023

PyArrow 14 started returning an option type, which follows from the new null_matching_behavior option.

@jpivarski I'm wondering about the _drop_option_preserving_form helper function that we use to erase options. Should we only check the bitmasks being erased in our test suite? i.e., at production, we don't assert that each entry is 0, but rather assume that the operation doesn't do this — the mask is just PyArrow adding a mask node?

Copy link

codecov bot commented Nov 1, 2023

Codecov Report

Merging #2792 (fb492c2) into main (2fbaa2c) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files
Files Coverage Δ
src/awkward/operations/str/__init__.py 100.00% <100.00%> (+0.88%) ⬆️
src/awkward/operations/str/akstr_index_in.py 97.14% <100.00%> (-0.08%) ⬇️
src/awkward/operations/str/akstr_is_in.py 97.14% <100.00%> (-0.08%) ⬇️

... and 1 file with indirect coverage changes

@agoose77 agoose77 temporarily deployed to docs November 1, 2023 18:03 — with GitHub Actions Inactive
Copy link
Member

@jpivarski jpivarski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is why Arrow's major version is increasing so rapidly: they change their API a lot!

Yes, this is good to merge, if it makes our string functions insensitive to this change in Arrow 14.

@agoose77 agoose77 enabled auto-merge (squash) November 1, 2023 20:00
@agoose77 agoose77 merged commit 9dc10a0 into main Nov 1, 2023
36 checks passed
@agoose77 agoose77 deleted the agoose77/fix-pyarrow-option branch November 1, 2023 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants