fix: support scalar strings in `fill_none` #2793

agoose77 · 2023-11-01T22:33:25Z

This regression was introduced by #2763. This PR ensures that strings are treated as scalars in fill_none.

codecov · 2023-11-01T22:39:17Z

Codecov Report

Merging #2793 (1cd13d9) into main (4ed2397) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Files	Coverage Δ
src/awkward/operations/ak_fill_none.py	`97.72% <ø> (ø)`

src/awkward/operations/ak_fill_none.py

jpivarski

Thanks for fixing this! It can be merged, which unblocks those releases.

agoose77 added 2 commits November 1, 2023 22:32

fix: identify strings as scalars

ce5c13b

test: add test for fill_none with bare strings

bdab514

agoose77 changed the title ~~fix: fill_none doesn't support bare strings~~ fix: support scalar strings in fill_none Nov 1, 2023

agoose77 requested a review from jpivarski November 1, 2023 22:34

agoose77 mentioned this pull request Nov 1, 2023

fix: drop lengths recursively #2775

Merged

agoose77 temporarily deployed to docs November 1, 2023 22:45 — with GitHub Actions Inactive

agoose77 commented Nov 1, 2023

View reviewed changes

src/awkward/operations/ak_fill_none.py Outdated Show resolved Hide resolved

Update src/awkward/operations/ak_fill_none.py

8b7d679

agoose77 temporarily deployed to docs November 1, 2023 23:12 — with GitHub Actions Inactive

Merge branch 'main' into agoose77/fix-fill-none-promotion

1cd13d9

agoose77 deployed to docs November 3, 2023 15:10 — with GitHub Actions View deployment

jpivarski approved these changes Nov 3, 2023

View reviewed changes

agoose77 merged commit c01efd8 into main Nov 3, 2023
36 checks passed

agoose77 deleted the agoose77/fix-fill-none-promotion branch November 3, 2023 17:52