fix: support arbitrary ufuncs with respect to NEP-50 #2799
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files
|
|
Hmm, test fails on Windows. Let me perhaps choose some different types to avoid the 32-bit aspect to this. I'll use a typed |
Ah, as I suspected this is actually the default int type, not int64
agoose77
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR takes into consideration the failure of Numba ufuncs in our NEP-50 aware machinery. It's unfortunate that this has taken a subsequent PR, but in retrospect we should have duck-typed this from the beginning.
Now, we just ask the ufunc object if it supports NEP-50 via
resolve_dtypes. In future, we should gracefully support Numba's implementation, assuming that it implements this in a similar way to NumPy, which it ought to.Our test suite will fail once Numba >=0.59.0 is available, because we can't know for certain what kind of exception it will throw. Thus, we'll catch that at the time and implement the correct exception handler in pytest.