Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: drop forget_length in typetracer_with_report #2807

Merged
merged 4 commits into from
Nov 11, 2023

Conversation

agoose77
Copy link
Collaborator

@agoose77 agoose77 commented Nov 8, 2023

This PR follows the deprecation schedule to remove this argument.

@agoose77 agoose77 changed the title feat!: drop forget_length in typetracer_with_report feat!: drop forget_length in typetracer_with_report Nov 8, 2023
@agoose77
Copy link
Collaborator Author

agoose77 commented Nov 8, 2023

As this is a deprecation PR, we've already agreed upon it's contents, so I'm happy to merge without Jim's input.

@agoose77 agoose77 enabled auto-merge (squash) November 8, 2023 22:17
Copy link

codecov bot commented Nov 8, 2023

Codecov Report

Merging #2807 (dc35375) into main (ec261c2) will increase coverage by 0.00%.
Report is 1 commits behind head on main.
The diff coverage is 33.33%.

Additional details and impacted files
Files Coverage Δ
src/awkward/typetracer.py 89.65% <100.00%> (+0.76%) ⬆️
src/awkward/_nplikes/typetracer.py 74.91% <0.00%> (+0.08%) ⬆️

... and 1 file with indirect coverage changes

@agoose77 agoose77 merged commit ad04fc7 into main Nov 11, 2023
36 checks passed
@agoose77 agoose77 deleted the agoose77/feat!-drop-forget-length-typetracer branch November 11, 2023 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant