Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: export more of typetracer #2816

Merged
merged 3 commits into from
Nov 14, 2023
Merged

Conversation

agoose77
Copy link
Collaborator

Now that dask-awkward is stabilising, it's clear that we need to export some more of our internals. In this PR, I add a constructor for unknown scalars, but not for arrays. This is a very restrictive approach, but I think we want to keep things as locked down as possible until we have a clearer sense of what's needed besides unknown scalars.

Copy link
Member

@jpivarski jpivarski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! It's ready to merge.

@agoose77 agoose77 enabled auto-merge (squash) November 14, 2023 10:36
Copy link

codecov bot commented Nov 14, 2023

Codecov Report

Merging #2816 (2aa118c) into main (cac9348) will increase coverage by 0.00%.
Report is 1 commits behind head on main.
The diff coverage is 85.71%.

Additional details and impacted files
Files Coverage Δ
src/awkward/typetracer.py 89.06% <85.71%> (-0.60%) ⬇️

@agoose77 agoose77 merged commit 2c75c0f into main Nov 14, 2023
38 checks passed
@agoose77 agoose77 deleted the agoose77/feat-export-typetracer branch November 14, 2023 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants