Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: only compare scalars in full_like #2857

Merged
merged 3 commits into from
Nov 30, 2023
Merged

fix: only compare scalars in full_like #2857

merged 3 commits into from
Nov 30, 2023

Conversation

agoose77
Copy link
Collaborator

@agoose77 agoose77 commented Nov 29, 2023 •
edited
Loading

Currently we follow a ufunc branch in full_like, which can be avoided. This branch may fail for non-castable fill-value dtypes e.g. datetime64.

@agoose77 agoose77 mentioned this pull request Nov 29, 2023
Merged
@codecov Codecov
Copy link

codecov bot commented Nov 29, 2023

Codecov Report

Merging #2857 (9a3cfa5) into main (3c2940c) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Additional details and impacted files
Files Coverage Δ
src/awkward/operations/ak_full_like.py 98.38% <100.00%> (+0.02%) ⬆️

... and 1 file with indirect coverage changes

@agoose77 agoose77 changed the title fix: full like dtype fix: only compare scalars in full_like Nov 29, 2023
@agoose77
Copy link
Collaborator Author

This is simple and blocking dask-awkward CI; I'll merge.

@agoose77 agoose77 merged commit f61ddc0 into main Nov 30, 2023
40 checks passed
@agoose77 agoose77 deleted the agoose77/fix-full-like-dtype branch November 30, 2023 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpivarski jpivarski Awaiting requested review from jpivarski

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@agoose77