-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: remove obsolete cuda_kernels #2876
Conversation
@jpivarski @ianna
I see that they have a different if condition. But since their |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is good to do as a first step, so that you don't accidentally spend time on obsolete kennels. The number of removed kennels doesn't surprise me—going from v1 to v2, it became possible to use NumPy in places where we previously needed custom kernels. For the GPU, CuPy takes that role (assuming that CuPy is a good replacement for NumPy in those places, which it very likely is, and if not, a shim in its nplike would fix it).
I'd say you can merge when ready. You only need one review, not two, although if @ianna has anything to say about this, please do!
@jpivarski These two should be removed too right?
|
If you don't see them in v2, then yes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ManasviGoyal - looks good to me! please, merge it when you are done with it. Thanks!
eb1f30c
to
46f7f54
Compare
Removed the following
cuda_kernels
which had a correspondingcpu-kernels
inv1
but not inv2
:This one was in none of the versions: