-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: register Numba in test #2879
Conversation
5686284
to
d36a8b0
Compare
@jpivarski I simplified this to only address a missing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@agoose77 - I think we also need to check on the numba
version greater or equal to 0.58
to avoid specifying the types for vectorise. Perhaps, adding a warning in case the version does not support it yet?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
About the minimum Numba version: it's true that @nb.vectorize
without explicit arguments won't work before a certain Numba version, but that could be described as something missing from Numba, rather than something missing from Awkward.
In addition, @nb.vectorize
is not a very popular function. This plot comes from static analysis of all the non-fork repos that import numba
(or from numba import
):
(If Numba is imported as another name, like nb
, this includes nb.vectorize
, and the nb.jit
and nb.njit
have been folded such that nb.jit
with nopython=True
counts as nb.njit
only.)
So it doesn't seem necessary to me for Awkward to require a much newer Numba version just for vectorize
. Since the Numba dependency is not managed by pip/conda (it's an optional dependency), dealing with mismatched version numbers is more annoying, as it's something the user must do manually.
All of the tests pass. @ianna, if you agree, you can do the merge. If not, let me know your reasons and we'll talk! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @jpivarski! Yes, I agree, let's merge it!
This PR recognises that Numba isn't being registered for a specific test, and fixes it!