-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: support revertable for concatenate in pyarrow logic #2889
Conversation
Codecov Report
Additional details and impacted files
|
@jpivarski this fixes #2884, though I think we should refactor this logic down the road to obviate the need for the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was about to look into #2884, but you've already solved it!
Your use of is_revertable
is more formal than the getattr
with a default that I would have done, but this is good, as it leads the way toward type annotations.
This PR is good to merge!
Fixes #2884