-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: configure Julia version and required packages #2896
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this need to be added to a MANIFEST or something to be available to users who install awkward from the sdist or from a wheel? We want this to work for users who install through pip and conda, not just by checking out GitHub.
Also, I suppose the version number will need to be updated after every AwkwardArray.jl release. Can it be set to "latest"? If not, that's okay. It will just become part of our normal workflow to increase this number after an AwkwardArray.jl release becomes public.
Otherwise, this is good! We should do whatever is necessary to streamline the interface between Python and Julia.
@ianna from the README, it looks like we want this file to exist under |
I've modified the build configuration. We should explicitly check that editable installs perform this rewrite (they should, though; hatch uses the wheel target). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@agoose77 and @jpivarski - I think, this is good to be merged. Thanks!
Okay, I'll add this to the set that are being tested and will be included in awkward 2.5.2. Thanks! |
The Python module JuliaCall can be installed as follows:
Here is how it works (see JuliaPkg for more details):