Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add string builder #2899

Merged
merged 13 commits into from
Jan 29, 2024
Merged

feat: add string builder #2899

merged 13 commits into from
Jan 29, 2024

Conversation

lobis
Copy link
Contributor

@lobis lobis commented Dec 14, 2023

Add a string builder to the header-only library to make building arrays of strings easier.

Copy link

codecov bot commented Dec 14, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (28007e9) 81.88% compared to head (cb566d6) 81.98%.

❗ Current head cb566d6 differs from pull request most recent head 9d3b826. Consider uploading reports for the commit 9d3b826 to get more accurate results

Additional details and impacted files

see 27 files with indirect coverage changes

Copy link
Collaborator

@ianna ianna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lobis - looks great! I don't think clang-format was run. Could you please run it by hand? Thanks!

header-only/layout-builder/awkward/LayoutBuilder.h Outdated Show resolved Hide resolved
@lobis
Copy link
Contributor Author

lobis commented Dec 14, 2023

By the way I noticed that there is not clang-format in the pre-commit

@lobis - looks great! I don't think clang-format was run. Could you please run it by hand? Thanks!

I manually formatted the file (no clang-format).

I wasn't able to run clang-format without causing a huge diff so I created a separate PR for this (#2902).

@lobis lobis marked this pull request as ready for review December 20, 2023 13:56
@lobis lobis requested a review from ianna December 20, 2023 13:57
Copy link
Collaborator

@ianna ianna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lobis - Thanks, it looks good to me.

Copy link
Member

@jpivarski jpivarski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks! I approve it as well.

I'm pretty sure this will automatically pass all of the test (unless there's a C++ compilation error or something).

Is it ready to merge, assuming that it does pass tests?

@lobis
Copy link
Contributor Author

lobis commented Jan 29, 2024

Great, thanks! I approve it as well.

I'm pretty sure this will automatically pass all of the test (unless there's a C++ compilation error or something).

Is it ready to merge, assuming that it does pass tests?

Ready!

@jpivarski jpivarski merged commit 9191df2 into scikit-hep:main Jan 29, 2024
38 checks passed
@jpivarski
Copy link
Member

@all-contributors please add @lobis for code

Copy link
Contributor

@jpivarski

I've put up a pull request to add @lobis! 🎉

@lobis lobis deleted the string-builder branch February 2, 2024 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants