fix: touching of unions #2906
Merged
fix: touching of unions #2906
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agoose77
force-pushed
the
agoose77/fix-broadcast-touching
branch
from
bed2688
to
8294cc4
Compare
Codecov ReportAttention:
Additional details and impacted files
|
* ci: simplify test workflow * ci: try exporting ForthError * ci: use macos11 for now * ci: rename General to Test * ci: fix wheelhouse path * ci: better parameterisation * ci: try cross-platform * ci: use glob action * ci: fix ROOT workflow * ci: fix defaults * ci: fixes * ci: fixes * fix: remaining paths
agoose77
commented
Dec 19, 2023
agoose77
commented
Dec 19, 2023
agoose77
commented
Dec 19, 2023
agoose77
commented
Dec 19, 2023
agoose77
force-pushed
the
main
branch
2 times, most recently
from
ed5c6df
to
f6d6f5c
Compare
jpivarski
approved these changes
Dec 20, 2023
There was a problem hiding this comment.
That's right: since an element of a union can be any of its contents, and it doesn't get unpacked by the user explicitly specifying a field name, touching a union must touch all of its contents.
It looks like this PR also has the CI improvements. Maybe that's because it has been merged into this but not main yet.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Broadcasting of unions should also touch the contents! Fixes #2905