-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: touching of unions #2906
fix: touching of unions #2906
Conversation
bed2688
to
8294cc4
Compare
Codecov ReportAttention:
Additional details and impacted files
|
* ci: simplify test workflow * ci: try exporting ForthError * ci: use macos11 for now * ci: rename General to Test * ci: fix wheelhouse path * ci: better parameterisation * ci: try cross-platform * ci: use glob action * ci: fix ROOT workflow * ci: fix defaults * ci: fixes * ci: fixes * fix: remaining paths
ed5c6df
to
f6d6f5c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's right: since an element of a union can be any of its contents, and it doesn't get unpacked by the user explicitly specifying a field name, touching a union must touch all of its contents.
It looks like this PR also has the CI improvements. Maybe that's because it has been merged into this but not main
yet.
Broadcasting of unions should also touch the contents! Fixes #2905