Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: include header-only files in sdist #2909

Merged
merged 3 commits into from
Dec 20, 2023

Conversation

agoose77
Copy link
Collaborator

@agoose77 agoose77 commented Dec 19, 2023

Fixes #2897 by ensuring that our SDist includes the header-only files. This is necessary both because semantically the SDist should represent a snapshot of the repo (in our case a generated snapshot), and because it's possible to build wheels from SDists, which is not possible if files are missing.

Copy link

codecov bot commented Dec 19, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1cc22e5) 81.98% compared to head (7f01673) 81.98%.

Additional details and impacted files

Copy link
Member

@jpivarski jpivarski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, good—this is another way to get header-only code, though I would think that users ordinarily wouldn't get it in a Python package; they'd use the CMakeLists fetch or explicitly download it...

Nope: the motivation for this is to make it possible to compile from the sdist. Full steam ahead!

@agoose77 agoose77 merged commit 1c52490 into main Dec 20, 2023
39 of 40 checks passed
@agoose77 agoose77 deleted the agoose77/fix-header-only-inclusion branch December 20, 2023 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Header-only libraries are not included in SDist archives
2 participants