-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: ak.std and ak.var for axis != -1. #2918
Conversation
Codecov ReportAttention:
Additional details and impacted files
|
This is probably the same issue as #2760, so we should look at |
Note to self:
|
I noticed this in association with softmax when I had to turn a test from xfail to normal. I haven't looked at softmax yet, but it's likely the same issue of trying to compute it by calling the other semi-reducer functions 1. For About the precision, it would be a bad surprise for different Footnotes
|
Although$\frac{1}{n}\sum_i (x_i - \mbox{mean}(x))^2$ is more precise than $(\frac{1}{n}\sum_i x_i^2) - \mbox{mean}(x)$ , the latter can only be broadcasted when
axis=-1
. This had been failing without a useful error message; now it works (with less precision).