Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: only run test for specific Numba version #2921

Merged
merged 2 commits into from
Jan 11, 2024

Conversation

agoose77
Copy link
Collaborator

@agoose77 agoose77 commented Jan 3, 2024

Fixes #2878

@agoose77 agoose77 enabled auto-merge (squash) January 3, 2024 16:09
Copy link

codecov bot commented Jan 3, 2024

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (d466d70) 81.98% compared to head (9dcb061) 81.94%.

Additional details and impacted files
Files Coverage Δ
src/awkward/_connect/pyarrow.py 90.57% <ø> (ø)
src/awkward/_nplikes/typetracer.py 74.85% <100.00%> (ø)
src/awkward/forms/emptyform.py 82.45% <100.00%> (-2.27%) ⬇️
src/awkward/forms/unionform.py 80.68% <ø> (ø)
src/awkward/operations/ak_enforce_type.py 81.97% <100.00%> (ø)
src/awkward/operations/str/__init__.py 100.00% <ø> (ø)
src/awkward/typetracer.py 89.06% <100.00%> (ø)
src/awkward/contents/indexedoptionarray.py 88.15% <0.00%> (ø)
src/awkward/forms/numpyform.py 78.29% <50.00%> (-2.56%) ⬇️
src/awkward/operations/ak_concatenate.py 85.14% <50.00%> (ø)
... and 1 more

... and 1 file with indirect coverage changes

@agoose77
Copy link
Collaborator Author

agoose77 commented Jan 4, 2024

Depends upon fixing #2920

@agoose77 agoose77 self-assigned this Jan 5, 2024
@jpivarski
Copy link
Member

Since the fix in this PR is also a blocker for #2920 (mutual blockers), I'll fix #2920 here in this branch. I don't think you're actively working on it or have unmerged local changes, but let me know if I'm wrong.

@jpivarski
Copy link
Member

Well, this error is different. Didn't we see it before? Is it getting a version of pyarrow that has a bug in one of its string functions?

']] != [['', '→δε←', '', ''], ['', 'ζz', 'zζ', '', ''], ['', 'abc', '', '']]
2024-01-10T21:03:55.4542990Z E         Full diff:
2024-01-10T21:03:55.4543300Z E           [
2024-01-10T21:03:55.4543730Z E            [['', 'αβγ', '', ''], ['', '', '']],
2024-01-10T21:03:55.4544150Z E            [],
2024-01-10T21:03:55.4545310Z E         -  [['', '→δε←', '', ''], ['', 'ζz', 'zζ', '', ''], ['', 'abc', '', '']],
2024-01-10T21:03:55.4545960Z E         ?                                                                ^^^^
2024-01-10T21:03:55.4546680Z E         +  [['', '→δε←', '', ''], ['', 'ζz', 'zζ', '', ''], ['', 'abc', ' ']],
2024-01-10T21:03:55.4547240Z E         ?                                                                ^
2024-01-10T21:03:55.4547680Z E           ]
2024-01-10T21:03:55.4547850Z 
2024-01-10T21:03:55.4547860Z 
2024-01-10T21:03:55.4548660Z tests/test_2616_use_pyarrow_for_strings.py:932: AssertionError
2024-01-10T21:03:55.4549100Z 
2024-01-10T21:03:55.4549510Z ---------- 

@agoose77
Copy link
Collaborator Author

agoose77 commented Jan 11, 2024

@jpivarski yes, that's a flaky test on MacOS. I reported it to PyArrow IIRC, but it's not exactly easy to find a reproducer! It seems to only happen on one MacOS test sometimes.

I'm re-running the test job that failed.

@agoose77 agoose77 merged commit e86b149 into main Jan 11, 2024
38 checks passed
@agoose77 agoose77 deleted the agoose77/test-check-tight-numba-version branch January 11, 2024 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants