-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: restore files that generated the type-parser #2926
Conversation
pre-commit should not be allowed to modify auto-generated code. Or any of these files; they're for historical reference. This reverts commit fd96676.
Huh, this was around at some point. Didn't realise we lost them! Good catch. |
@ianna was right (in a now-deleted comment). These were saved, but they were in the These diffs are not too big: diff dev/typeparser/parser.py studies/type-parser/parser.py
diff dev/typeparser/type-grammar.lark studies/type-parser/grammar.lark I can confirm that studies/type-parser-2 (added in #1514) is the most recent; it added our current src/awkward/types/_awkward_datashape_parser.py and there have been no substantial changes to it since then. |
One test is failing because of #2920. I'll get to that later. |
The other tests aren't running because this PR only puts data into the studies/ directory, so it's sufficiently tested to merge. |
This is how src/awkward/types/_awkward_datashape_parser.py was made.
These files were taken from 4ba1dbb (#1514), the last commit before they disappeared in the v1 → v2 transition. I think this was their final state—I think they weren't developed any further. (Am I missing anything, @reikdas?)
These should remain in the dev directory in case we ever need to make changes to the grammar or update the generated file to a new Lark version or a new Python version.
For reference, the auto-generated file was made according to the procedure documented in
Since this PR only touches files in the dev directory, I'm going to merge it without review.