Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: generate unit tests for cpu and cuda #2938

Merged
merged 16 commits into from
Jan 19, 2024

Conversation

ManasviGoyal
Copy link
Collaborator

@ManasviGoyal ManasviGoyal commented Jan 12, 2024

Generated unit-tests for cpu-kernels (4978 tests which run in the CI too) and cuda-kernels. For now, I have added a status in the kernel-test-data.json to turn off the cuda tests. As I will fix/add the kernels, I will turn the tests for the kernels on.

@ManasviGoyal ManasviGoyal added the gpu Concerns the GPU implementation (backend = "cuda') label Jan 12, 2024
Copy link

codecov bot commented Jan 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9d93512) 81.88% compared to head (27af67a) 81.88%.
Report is 8 commits behind head on main.

Additional details and impacted files

@ManasviGoyal ManasviGoyal force-pushed the ManasviGoyal/generate-unit-tests-for-cuda-kernels branch 2 times, most recently from 706b7fc to 3104632 Compare January 15, 2024 16:24
@ManasviGoyal ManasviGoyal force-pushed the ManasviGoyal/generate-unit-tests-for-cuda-kernels branch from 2cb9702 to e8820ec Compare January 17, 2024 21:21
@ManasviGoyal ManasviGoyal changed the title feat: generate unit tests for cuda tests: generate unit tests for cpu and cuda Jan 18, 2024
@ManasviGoyal ManasviGoyal force-pushed the ManasviGoyal/generate-unit-tests-for-cuda-kernels branch from e8820ec to 7e89d12 Compare January 18, 2024 10:55
@ManasviGoyal ManasviGoyal changed the title tests: generate unit tests for cpu and cuda test: generate unit tests for cpu and cuda Jan 18, 2024
@ManasviGoyal ManasviGoyal force-pushed the ManasviGoyal/generate-unit-tests-for-cuda-kernels branch from ce0448b to 282445a Compare January 19, 2024 08:08
@ManasviGoyal ManasviGoyal force-pushed the ManasviGoyal/generate-unit-tests-for-cuda-kernels branch from 282445a to eff0c94 Compare January 19, 2024 09:03
@ManasviGoyal ManasviGoyal force-pushed the ManasviGoyal/generate-unit-tests-for-cuda-kernels branch from c4d9766 to bd0515c Compare January 19, 2024 09:06
Copy link
Member

@jpivarski jpivarski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good! It adds the tests that you need, you can toggle them with status, I just checked it out and tried them (all good), and I see that they're running in CI.

This can be merged; do so whenever you're ready!

@jpivarski
Copy link
Member

Oh, one other thing: you'll want to include these new directories in .gitignore.

Don't merge yet—I'll add them.

@jpivarski
Copy link
Member

Okay, now it can be merged, when you're ready.

@ManasviGoyal
Copy link
Collaborator Author

Oh, one other thing: you'll want to include these new directories in .gitignore.

Don't merge yet—I'll add them.

There is another .gitignore in the awkward-cpp where all the cpu tests are being ignored. I'll remove them from there since it is redundant.

@ManasviGoyal ManasviGoyal removed the request for review from ianna January 19, 2024 20:10
@ManasviGoyal ManasviGoyal merged commit f9a29ef into main Jan 19, 2024
39 checks passed
@ManasviGoyal ManasviGoyal deleted the ManasviGoyal/generate-unit-tests-for-cuda-kernels branch January 19, 2024 20:14
@jpivarski
Copy link
Member

There is another .gitignore in the awkward-cpp where all the cpu tests are being ignored. I'll remove them from there since it is redundant.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gpu Concerns the GPU implementation (backend = "cuda')
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants