Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: don't fail fast (so pypy doesn't stop the tests) #2956

Merged
merged 2 commits into from
Jan 17, 2024

Conversation

jpivarski
Copy link
Member

No description provided.

Copy link

codecov bot commented Jan 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (882088a) 81.88% compared to head (1c28e71) 81.88%.

Additional details and impacted files

Copy link
Collaborator

@ManasviGoyal ManasviGoyal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All CPU tests are running now. Looks good!

@jpivarski jpivarski merged commit 9d93512 into main Jan 17, 2024
39 checks passed
@jpivarski jpivarski deleted the jpivarski/dont-fail-fast branch January 17, 2024 21:31
@agoose77
Copy link
Collaborator

agoose77 commented Jan 17, 2024

@jpivarski originally we skipped the tests if awkward-cpp had not changed. Is there a reason that this pr changes that?

@jpivarski
Copy link
Member Author

Hmmm. Maybe we'll go back to that. I see the logic that if the YAML specification doesn't change and the CPU implementations (in awkward-cpp) don't change, there's no reason to re-run their tests. While @ManasviGoyal is fixing the dev/generate-tests.py, the tests do change, so they need to run in CI. (Ideally, the if condition should check for changes in both awkward-cpp and this dev script.)

It's also likely to undergo a lot of changes in the near future as she adds cuda-kernel tests. Naturally, that motivates some fixes to the testing framework itself.

@agoose77
Copy link
Collaborator

Oh, I hadn't realised those tests were changing. We can perhaps extend the ci to handle that!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants