chore: fix ruff warnings #3010
Merged
chore: fix ruff warnings #3010
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ManasviGoyal this should hopefully appease ruff :) |
|
@jpivarski I set this to automerge, and it succeeded despite the pypy test failure. I assume that means we explicitly don't want this to be a required test? Have you seen that pypy segfault before? I don't think this PR did anything that would introduce it, so I'm wondering if it's flaky. |
|
It's #2971, a known issue. The reason it's not a required test is because of the segfault. I want to keep running the test, but not require it, to keep in mind that it's an unsolved problem. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes some ruff warnings that have appeared. Some are general, some are NumPy.