Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make ak.mean and ak.count differentiable #3020

Merged
merged 4 commits into from
Mar 4, 2024

Conversation

Saransh-cpp
Copy link
Member

@Saransh-cpp Saransh-cpp commented Feb 12, 2024

Copy link

codecov bot commented Feb 13, 2024

Codecov Report

Attention: Patch coverage is 90.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 81.94%. Comparing base (b749e49) to head (9626bde).
Report is 27 commits behind head on main.

Additional details and impacted files
Files Coverage Δ
src/awkward/_connect/jax/reducers.py 87.50% <90.00%> (+1.29%) ⬆️

... and 2 files with indirect coverage changes

@agoose77
Copy link
Collaborator

@Saransh-cpp is this stuck on anything? Just checking whether I can offer any help.

@Saransh-cpp
Copy link
Member Author

Hi @agoose77, the PR is ready for review; not stuck on anything!

Copy link
Member

@jpivarski jpivarski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good; I'll approve it!

And I'll merge it because it looks done.

src/awkward/_connect/jax/reducers.py Show resolved Hide resolved
@jpivarski jpivarski enabled auto-merge (squash) March 4, 2024 23:00
@jpivarski jpivarski merged commit d1bfb0e into scikit-hep:main Mar 4, 2024
39 checks passed
@Saransh-cpp Saransh-cpp deleted the make-mean-differentiable branch March 5, 2024 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Differentiating through an ak.mean
3 participants