Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: generate array view #3115

Merged
merged 15 commits into from
May 21, 2024

Conversation

ianna
Copy link
Collaborator

@ianna ianna commented May 13, 2024

fixes #3105

@ianna ianna linked an issue May 13, 2024 that may be closed by this pull request
Copy link
Collaborator Author

@ianna ianna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jpivarski - I think, this is fixes the issue. However, now I'm thinking what if the numba_type of the array does not match the numba type of the kernel?

src/awkward/_connect/numba/arrayview_cuda.py Outdated Show resolved Hide resolved
Copy link
Member

@jpivarski jpivarski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! You can merge when ready.

src/awkward/_connect/numba/arrayview_cuda.py Outdated Show resolved Hide resolved
Copy link
Collaborator Author

@ianna ianna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jpivarski - it's strange that the CPU tests on Mac are segfaulting. I'll check it locally.

@ianna
Copy link
Collaborator Author

ianna commented May 21, 2024

@jpivarski - all the tests pass. Shall I merge it? Thanks.

@jpivarski
Copy link
Member

Yes! In fact, I can do it, since you've just signed-off on it.

@jpivarski jpivarski merged commit a096f3d into main May 21, 2024
42 checks passed
@jpivarski jpivarski deleted the ianna/3105-typing-akarray-for-numbacudajit-signature branch May 21, 2024 04:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

typing ak.Array for numba.cuda.jit signature
2 participants