Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add 3.13 wheels #3217

Merged
merged 7 commits into from
Sep 12, 2024
Merged

ci: add 3.13 wheels #3217

merged 7 commits into from
Sep 12, 2024

Conversation

henryiii
Copy link
Member

Adding 3.13 (non-free-threaded at the moment).

@henryiii
Copy link
Member Author

  E       AssertionError: Regex pattern did not match.
  E        Regex: "Can't pickle"
  E        Input: "Can't get local object 'test_serialise_with_nonserialisable_attrs.<locals>.<lambda>'"

Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
@lgray
Copy link
Contributor

lgray commented Sep 3, 2024

@henryiii "cp313", "cp313t" are now available and numpy is also (as of a few hours ago) producing 3.13t wheels as well. Worth another try now!

@henryiii
Copy link
Member Author

henryiii commented Sep 3, 2024

Passing.

@lgray
Copy link
Contributor

lgray commented Sep 3, 2024

Guessing because of cramjam workaround we presently cannot test 3.13t?

@henryiii
Copy link
Member Author

henryiii commented Sep 4, 2024

3.13 works with the workaround. Either cramjam happens to work with it or we don’t use enough of it to be affected by any breakage.

3.13t probably not.

@henryiii
Copy link
Member Author

henryiii commented Sep 4, 2024

Ah, yes, you have the t.

@lgray
Copy link
Contributor

lgray commented Sep 4, 2024

Where do you see it in the tests? Or are you saying I'm asking for it and we don't have it? If the latter, I guess we just wait a bit for setup-python to make a release.

@henryiii
Copy link
Member Author

henryiii commented Sep 4, 2024

We aren't building 3.13t yet in cibuildwheel, so it's not built or tested. I'm assuming there's no chance this workaround works on 3.13t; I'm not even sure PyO3 main supports 3.13t yet.

For PyO3 (current, not old version), see Quansight-Labs/free-threaded-compatibility#53.

@jpivarski jpivarski self-requested a review September 4, 2024 20:34
@lgray
Copy link
Contributor

lgray commented Sep 5, 2024

@jpivarski
Copy link
Member

All the tests that this PR branch runs are now required, and nothing that it doesn't run is required. Now I'll update and auto-merge.

@jpivarski jpivarski enabled auto-merge (squash) September 12, 2024 17:41
@jpivarski jpivarski merged commit af0ccea into main Sep 12, 2024
60 checks passed
@jpivarski jpivarski deleted the henryiii/chore/313 branch September 12, 2024 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants