-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add ak.array_equal
to NEP18 overrides, documentation, and add one more test
#3225
Conversation
tcawlfield
commented
Aug 23, 2024
- Now overrides numpy.array_equal
- Adding link to toctree
- Unit test checks numpy override
* Now overrides numpy.array_equal * Adding link to toctree * Unit test checks numpy override
ak.array_equal
to documentation and add one more test
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is good; I agree that the heading :caption:
should be "approximation and comparison".
The first set of test failures are due to the fact that Awkward only supports native-endian numbers, and you have some tests that make big-endian unsigned int32. I don't know what the second issue is.
Once those are fixed, this is mergeable!
ak.array_equal
to documentation and add one more testak.array_equal
to NEP18 overrides, documentation, and add one more test
Oh, a regression failure! I'm seeing the first of these errors on my own system once I run all tests. Hmm. The failure is here.
I'll work on this. |
Using ensure_same_backend now, which raises an exception instead of returning False. This is a new behavior for ak.almost_equal. This also removes a shortcut in the code, and we get a NotImplementedError on a typetracer backend. Test_2678 updated to match this expectation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This makes sense (the update in ec93fd2): "same backend" is a broader criterion than someone is likely to be asking about when they ask whether two arrays are equal. Having it raise an error, like all of the other functions, is good for consistency.