Apply suggestions from code review

scikit-hep · Jun 8, 2024 · 36c637c · 36c637c
1 parent a77277a
commit 36c637c
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 6 deletions.
diff --git a/.github/workflows/emscripten.yaml b/.github/workflows/emscripten.yaml
@@ -39,7 +39,7 @@ jobs:
           actions-cache-folder: emsdk-cache
 
       - name: Build
-        run: pyodide build --exports whole_archive
+        run: CXXFLAGS=-fexceptions LDFLAGS=-fexceptions pyodide build --exports whole_archive
 
       - uses: actions/setup-node@v4
         with:

diff --git a/pyproject.toml b/pyproject.toml
@@ -117,11 +117,6 @@ sdist.exclude = [
 write_to = "src/boost_histogram/version.py"
 
 
-[tool.pyodide.build]
-cxxflags = "-fexceptions"
-ldflags = "-fexceptions"
-
-
 [tool.pytest.ini_options]
 minversion = "6.0"
 junit_family = "xunit2"