Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nanoevents uproot mapping in coffea v0.7.15 needs update for changes in uproot v4.2.4 (.awkward_form method) #686

Closed
btovar opened this issue Jun 21, 2022 · 2 comments
Labels
bug Something isn't working

Comments

@btovar
Copy link
Contributor

btovar commented Jun 21, 2022

Describe the bug

As seen in uproot issue scikit-hep/uproot5#614, the arguments of the .awkward_form method used in https://github.com/CoffeaTeam/coffea/blob/532c69afc8f837c6886542727d493b274d2e2c78/coffea/nanoevents/mapping/uproot.py#L94 have changed. The method now takes a second required argument context. To preserve the current default behavior, this argument should be set to:

{"index_format": "i64", "header": False, "tobject_header": True, "breadcrumbs": ()}

I have not checked if this method is used somewhere else in coffea. I can make this pr if you want.

@btovar btovar added the bug Something isn't working label Jun 21, 2022
@jpivarski
Copy link
Member

Well, actually, that's our fault; Uproot will change back. The method didn't have a leading underscore, so it's public and we (I) shouldn't be changing the interface without warning like that.

@aryan26roy is making the Interpretation.awkward_form methods accept the same arguments that they used to (which then immediately create the new context and pass that down through a bunch of internal awkward_form functions, separate from the Interpretation.awkward_form). Coffea will not need to change.

This will be deployed as Uproot 4.3.0, first in a line of bug-fix releases for Uproot 4, tagged from the new main-v4 branch. It will also be a test of this new v4 bug-fix workflow.

@jpivarski
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants